Skip to content

Scripts refactoring and CPD benchmarking docs#60

Merged
vkutuev merged 6 commits into
mainfrom
iraedeus/guide-benchmarking
Aug 4, 2025
Merged

Scripts refactoring and CPD benchmarking docs#60
vkutuev merged 6 commits into
mainfrom
iraedeus/guide-benchmarking

Conversation

@iraedeus
Copy link
Copy Markdown
Contributor

@iraedeus iraedeus commented Jul 22, 2025

  • Add scripts folder, moved all installation scripts. Put dependencies installation (poetry) inside scripts/
  • Changed README.md
  • Add guide for benchmarking
  • Add workflows runs for building check

@iraedeus iraedeus force-pushed the iraedeus/guide-benchmarking branch from 49cc6af to 022e96f Compare July 22, 2025 20:22
@iraedeus iraedeus marked this pull request as ready for review July 22, 2025 21:51
@iraedeus iraedeus requested review from alexdtat and vkutuev July 22, 2025 21:51
@iraedeus iraedeus changed the title Iraedeus/guide benchmarking Scripts refactoring and CPD benchmarking docs Jul 22, 2025
Copy link
Copy Markdown
Collaborator

@alexdtat alexdtat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one-liners are worse, I just had problems with the current ones when copypasted or ran them from IDE. Also I'm not sure about running an example during installation, would be glad to see @vkutuev opinion on these ones.

Comment thread docs/Guide CPD Benchmark.md Outdated
./scripts/install_user_linux.sh

- name: Run example
run: poetry run python example.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to have an example run in an installation file?

./scripts/install_user_windows.ps1
poetry add pyqt5-qt5==5.15.2

- name: Run example
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to have an example run in an installation file?



## Algorithm configure

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this section is empty?

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread docs/Guide CPD Benchmark.md Outdated
@iraedeus iraedeus force-pushed the iraedeus/guide-benchmarking branch from 5bbd842 to e39d870 Compare August 4, 2025 20:45
@vkutuev vkutuev merged commit de4a9fd into main Aug 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants